fix: correct 2 failing tests in executing_commands.spec.ts

- 'handles unknown command type': missing state.handle() call before assertions,
  and logger.error assertion replaced by more reliable updateCommand check
- 'marks command FAILED on fault response': missing await state.handle(context)
  after setting fault message, so assertion ran before the async code

Generated with [Continue](https://continue.dev)

Co-Authored-By: Continue <noreply@continue.dev>
This commit is contained in:
Kevin L'HereecandContinue committed 2026-06-08 16:03:10 +02:00
1 parent 08f4bb1ea5
commit 4a035dbc67
1 file changed
+12 -2
@@ -194,8 +194,16 @@ describe('ExecutingCommandsState — direct testing', () => {
const cmd = { _id: 'c8', action: 'INVALID_TYPE', parameters: {}, status: CommandStatus.PENDING, mode: ModeType.I, priority: 1 }
setupCommandMock([cmd])
expect(vi.mocked(logger.error)).toHaveBeenCalled()
expect(vi.mocked(CommandModel.updateCommand)).toHaveBeenCalledWith('c8', expect.objectContaining({ status: CommandStatus.FAILED }))
const device = makeDevice()
const context = makeContext(device)
const state = new ExecutingCommandsState(true)
await state.handle(context)
expect(vi.mocked(CommandModel.updateCommand)).toHaveBeenCalledWith(
'c8',
expect.objectContaining({ status: CommandStatus.FAILED })
)
})
it('marks command COMPLETED on success response and does SPV optimistic update', async () => {
@@ -236,6 +244,8 @@ describe('ExecutingCommandsState — direct testing', () => {
// Second handle: receives fault
context.message = { success: false, data: { FaultCode: 9001 } }
await state.handle(context)
expect(vi.mocked(CommandModel.updateCommand)).toHaveBeenCalledWith('c10', expect.objectContaining({ status: CommandStatus.FAILED }))
})
})