chore: harden config, strengthen frontend typing, fix UTF-8 mojibake
Security config (3.1): - config/session.ts: cookie.secure now follows app.inProduction instead of being hardcoded to false - config/shield.ts: enable CSP with baseline directives compatible with Vite dev server and Inertia (self + @viteDevUrl/@viteHmrUrl) Frontend typing (3.2): - Replace 'any' props with concrete types (Computer, Component, ComponentType, ComputerState) across computers/*.vue and components/*.vue, using the existing inertia/pages/types/UITypes.ts definitions - Fix UITypes.ts: export ComponentType/ComputerState, switch from interface to type (interfaces are never assignable to Inertia's ComponentProps index signature), drop the stale componentTypeId/componentStateId fields that didn't match the actual Lucid schema (real field is typeId, no component state exists) - Add an asPageProp() boundary cast in the two controllers: Lucid's serialize() returns a loosely typed ModelObject that isn't structurally assignable to the concrete page prop shapes (and the inertia/** tree is excluded from the backend tsconfig, so real types can't be imported directly across that boundary) UTF-8 mojibake fixes (3.3): - Repair broken accented characters (├®/├á/├┤ -> é/à/ô, Ôé¼ -> €) left over from a bad encoding during the GWT->Inertia migration, across ComponentEditor.vue, ComputerComponentsTable.vue, SimpleGallery.vue, TableComponent.vue, isAdminMode.ts and the custom directives Misc cleanup (3.5): - computer.ts: replace console.warn with the app logger (includes computerId) when .cost is accessed without preloading components
This commit is contained in:
1 parent
3579c9dfec
commit
94f89be605
19 files changed
+103
-48
No files matched your search
@@ -5,16 +5,34 @@ import { updateComponentValidator } from '#validators/Components/update'
|
||||
import Component from '#models/component'
|
||||
import ComponentType from '#models/component_type'
|
||||
|
||||
/**
|
||||
* Lucid's `serialize()` returns a loosely typed `ModelObject`
|
||||
* (`{ [key: string]: any }`). It is not structurally assignable to the
|
||||
* concrete prop shapes declared by the Vue pages (see
|
||||
* `inertia/pages/types/UITypes.ts`), which live in a separate TypeScript
|
||||
* project (the `inertia/**` tree is excluded from the backend tsconfig).
|
||||
* Since the controller fully controls which columns/relations are
|
||||
* preloaded and serialized, this cast documents that the runtime shape
|
||||
* matches what the page expects at this boundary.
|
||||
*/
|
||||
function asPageProp<T>(value: unknown): T {
|
||||
return value as T
|
||||
}
|
||||
|
||||
export default class ComponentsController {
|
||||
async index({ inertia, auth }: HttpContext) {
|
||||
const user = await auth.authenticate()
|
||||
const components = await Component.query().preload('type').where('userId', user.id)
|
||||
return inertia.render('components/index', { components: components.map((c) => c.serialize()) })
|
||||
return inertia.render('components/index', {
|
||||
components: asPageProp(components.map((c) => c.serialize())),
|
||||
})
|
||||
}
|
||||
|
||||
async create({ inertia }: HttpContext) {
|
||||
const types = await ComponentType.all()
|
||||
return inertia.render('components/create', { types: types.map((t) => t.serialize()) })
|
||||
return inertia.render('components/create', {
|
||||
types: asPageProp(types.map((t) => t.serialize())),
|
||||
})
|
||||
}
|
||||
|
||||
async store({ request, response, auth }: HttpContext) {
|
||||
@@ -39,7 +57,7 @@ export default class ComponentsController {
|
||||
.where('userId', user.id)
|
||||
.andWhere('id', componentId)
|
||||
.firstOrFail()
|
||||
return inertia.render('components/show', { component: component.serialize() })
|
||||
return inertia.render('components/show', { component: asPageProp(component.serialize()) })
|
||||
}
|
||||
|
||||
async edit({ params, auth, inertia }: HttpContext) {
|
||||
@@ -52,8 +70,8 @@ export default class ComponentsController {
|
||||
.andWhere('id', componentId)
|
||||
.firstOrFail()
|
||||
return inertia.render('components/edit', {
|
||||
component: component.serialize(),
|
||||
types: types.map((t) => t.serialize()),
|
||||
component: asPageProp(component.serialize()),
|
||||
types: asPageProp(types.map((t) => t.serialize())),
|
||||
})
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user