From 3579c9dfece42c80634b7d3ea2bdd37079f7c19d Mon Sep 17 00:00:00 2001
From: Kevin L'Hereec <kevin.lhereec@orange.com>
Date: Thu, 23 Jul 2026 11:10:17 +0200
Subject: [PATCH] refactor: uniform validation, fix create form UX, dedupe
 filter dropdowns

- Remove dead registerValidator (Auth/register.ts), unused since signupValidator
  is the one actually wired to NewAccountController
- computers/create.vue: switch to useForm() + @submit.prevent so the form
  submits on Enter and shows a processing state, matching components/create.vue
- components/edit.vue: drop the 'origin' field, which was never provided by
  the backend (edit() never shared it) and therefore always undefined
- Extract FilterDropdown.vue and reuse it in ComponentsViewer/ComputersViewer,
  removing ~80 lines of duplicated dropdown markup/logic and fixing duplicate
  HTML ids (id="used" appeared twice in ComputersViewer)
- Move MIGRATION_*.md artifacts into docs/migration-history/
---
 .adonisjs/server/pages.d.ts                   |   1 +
 app/validators/Auth/register.ts               |  15 --
 .../migration-history/MIGRATION_CHECKLIST.md  |   0
 .../migration-history/MIGRATION_COMPLETE.md   |   0
 .../MIGRATION_PAGES_SUMMARY.md                |   0
 inertia/pages/components/edit.vue             |   9 +-
 inertia/pages/computers/create.vue            |  56 ++++--
 inertia/pages/widgets/ComponentsViewer.vue    | 167 +++---------------
 inertia/pages/widgets/ComputersViewer.vue     | 105 +++--------
 inertia/pages/widgets/FilterDropdown.vue      |  72 ++++++++
 10 files changed, 163 insertions(+), 262 deletions(-)
 delete mode 100644 app/validators/Auth/register.ts
 rename MIGRATION_CHECKLIST.md => docs/migration-history/MIGRATION_CHECKLIST.md (100%)
 rename MIGRATION_COMPLETE.md => docs/migration-history/MIGRATION_COMPLETE.md (100%)
 rename MIGRATION_PAGES_SUMMARY.md => docs/migration-history/MIGRATION_PAGES_SUMMARY.md (100%)
 create mode 100644 inertia/pages/widgets/FilterDropdown.vue

diff --git a/.adonisjs/server/pages.d.ts b/.adonisjs/server/pages.d.ts
index f6a826b..d2c4aa1 100644
--- a/.adonisjs/server/pages.d.ts
+++ b/.adonisjs/server/pages.d.ts
@@ -37,5 +37,6 @@ declare module '@adonisjs/inertia/types' {
     'widgets/SimpleGallery': ExtractProps<(typeof import('../../inertia/pages/widgets/SimpleGallery.vue'))['default']>
     'widgets/TableComponent': ExtractProps<(typeof import('../../inertia/pages/widgets/TableComponent.vue'))['default']>
     'widgets/ValidationError': ExtractProps<(typeof import('../../inertia/pages/widgets/ValidationError.vue'))['default']>
+    'widgets/FilterDropdown': ExtractProps<(typeof import('../../inertia/pages/widgets/FilterDropdown.vue'))['default']>
   }
 }
diff --git a/app/validators/Auth/register.ts b/app/validators/Auth/register.ts
deleted file mode 100644
index c5fce1c..0000000
--- a/app/validators/Auth/register.ts
+++ /dev/null
@@ -1,15 +0,0 @@
-import vine from '@vinejs/vine'
-
-export const registerValidator = vine.compile(
-  vine.object({
-    name: vine.string().minLength(3).maxLength(64),
-    email: vine
-      .string()
-      .email()
-      .unique(async (query, field) => {
-        const user = await query.from('users').where('email', field).first()
-        return !user
-      }),
-    password: vine.string().minLength(8).maxLength(32),
-  })
-)
diff --git a/MIGRATION_CHECKLIST.md b/docs/migration-history/MIGRATION_CHECKLIST.md
similarity index 100%
rename from MIGRATION_CHECKLIST.md
rename to docs/migration-history/MIGRATION_CHECKLIST.md
diff --git a/MIGRATION_COMPLETE.md b/docs/migration-history/MIGRATION_COMPLETE.md
similarity index 100%
rename from MIGRATION_COMPLETE.md
rename to docs/migration-history/MIGRATION_COMPLETE.md
diff --git a/MIGRATION_PAGES_SUMMARY.md b/docs/migration-history/MIGRATION_PAGES_SUMMARY.md
similarity index 100%
rename from MIGRATION_PAGES_SUMMARY.md
rename to docs/migration-history/MIGRATION_PAGES_SUMMARY.md
diff --git a/inertia/pages/components/edit.vue b/inertia/pages/components/edit.vue
index 4ca2301..f4f0078 100644
--- a/inertia/pages/components/edit.vue
+++ b/inertia/pages/components/edit.vue
@@ -3,14 +3,14 @@ import { reactive } from 'vue'
 import { Link } from '@adonisjs/inertia/vue'
 import { usePage } from '@inertiajs/vue3'
 import CustomSelect from '~/pages/widgets/CustomSelect.vue'
+import type { Component, ComponentType } from '~/pages/types/UITypes'
 
 const { props } = usePage<{
-  component: any
-  types: any[]
-  origin: string
+  component: Component
+  types: ComponentType[]
   errors?: Record<string, string>
 }>()
-const { component, types, origin } = props
+const { component, types } = props
 
 const form = reactive({
   id: component.id,
@@ -18,7 +18,6 @@ const form = reactive({
   price: component.price,
   typeId: component.type.id,
   purchaseDate: component.purchaseDate,
-  origin: origin,
 })
 </script>
 
diff --git a/inertia/pages/computers/create.vue b/inertia/pages/computers/create.vue
index 9981a92..28fd668 100644
--- a/inertia/pages/computers/create.vue
+++ b/inertia/pages/computers/create.vue
@@ -1,11 +1,12 @@
 <script setup lang="ts">
-import { computed, reactive } from 'vue'
+import { computed } from 'vue'
 import { Link } from '@adonisjs/inertia/vue'
-import { usePage } from '@inertiajs/vue3'
+import { useForm, usePage } from '@inertiajs/vue3'
+import type { Component, ComputerState } from '~/pages/types/UITypes'
 
 const { props } = usePage<{
-  components: any[]
-  states: any[]
+  components: Component[]
+  states: ComputerState[]
   errors: Record<string, string>
 }>()
 const { components, states } = props
@@ -26,7 +27,7 @@ const componentTypeOrder = [
 ]
 
 const componentsByType = computed(() => {
-  const groups = new Map<string, any[]>()
+  const groups = new Map<string, Component[]>()
   components.forEach((component) => {
     if (!groups.has(component.type.name)) {
       groups.set(component.type.name, [])
@@ -38,21 +39,35 @@ const componentsByType = computed(() => {
     .sort((a, b) => componentTypeOrder.indexOf(a.type) - componentTypeOrder.indexOf(b.type))
 })
 
-const form = reactive({
+const form = useForm<{
+  title: string
+  sellPrice: number
+  gpuScore: number
+  cpuScore: number
+  stateId: number
+  globalScore: number
+  componentsId: number[]
+  pictures: Record<string, never>[]
+}>({
   title: '',
   sellPrice: 0,
   gpuScore: 0,
   cpuScore: 0,
   stateId: 1,
   globalScore: 0,
-  componentsId: [] as number[],
+  componentsId: [],
+  pictures: [],
 })
+
+function submitForm() {
+  form.post('/computers')
+}
 </script>
 
 <template>
   <div class="max-w-4xl mx-auto p-8 bg-white shadow-lg rounded-lg">
     <h1 class="text-2xl font-semibold mb-8 text-gray-800">Create New Computer</h1>
-    <form class="space-y-6">
+    <form class="space-y-6" @submit.prevent="submitForm">
       <div class="mt-2">
         <label class="block text-gray-700 text-sm font-bold mb-2" for="title">Title</label>
         <input
@@ -149,16 +164,21 @@ const form = reactive({
         </div>
       </div>
 
-      <Link
-        href="/computers"
-        type="button"
-        as="button"
-        method="post"
-        :data="form"
-        class="px-4 py-2 bg-indigo-600 text-white rounded hover:bg-blue-700 transition"
-      >
-        Create
-      </Link>
+      <div class="flex gap-4">
+        <button
+          type="submit"
+          :disabled="form.processing"
+          class="px-4 py-2 bg-indigo-600 text-white rounded hover:bg-indigo-700 transition disabled:opacity-50"
+        >
+          {{ form.processing ? 'Creating…' : 'Create' }}
+        </button>
+        <Link
+          href="/computers"
+          class="px-4 py-2 bg-gray-300 text-gray-800 rounded hover:bg-gray-400 transition"
+        >
+          Cancel
+        </Link>
+      </div>
     </form>
   </div>
 </template>
diff --git a/inertia/pages/widgets/ComponentsViewer.vue b/inertia/pages/widgets/ComponentsViewer.vue
index 9113335..7934c3f 100644
--- a/inertia/pages/widgets/ComponentsViewer.vue
+++ b/inertia/pages/widgets/ComponentsViewer.vue
@@ -1,6 +1,7 @@
 <script setup lang="ts">
-import { computed, reactive, ref } from 'vue'
+import { computed, ref } from 'vue'
 import TableComponent from '~/pages/widgets/TableComponent.vue'
+import FilterDropdown from '~/pages/widgets/FilterDropdown.vue'
 import type Component from '#models/component'
 import type ComponentType from '#models/component_type'
 import { usePage } from '@inertiajs/vue3'
@@ -8,19 +9,6 @@ import { usePage } from '@inertiajs/vue3'
 const { props } = usePage<{ components: Component[] }>()
 const { components } = props
 
-const usageDropdownOpen = ref(false)
-const typeDropdownOpen = ref(false)
-
-function toggleDropdown(dropdown: any) {
-  if (dropdown === 'usage') {
-    usageDropdownOpen.value = !usageDropdownOpen.value
-    typeDropdownOpen.value = false
-  } else if (dropdown === 'type') {
-    typeDropdownOpen.value = !typeDropdownOpen.value
-    usageDropdownOpen.value = false
-  }
-}
-
 const componentTypes = computed(() => {
   const types = new Map<number, ComponentType>()
   components.forEach((component) => {
@@ -31,152 +19,51 @@ const componentTypes = computed(() => {
   return Array.from(types.values())
 })
 
-// D├®finir le type de l'objet filters
-interface Filters {
-  showUsed: boolean
-  showUnused: boolean
-  types: { [key: number]: boolean }
-}
+const typeOptions = computed(() =>
+  componentTypes.value.map((type) => ({ id: type.id, label: type.name }))
+)
 
-const filters = reactive<Filters>({
-  showUsed: false,
-  showUnused: true,
-  types: componentTypes.value.reduce(
+const usageFilters = ref<Record<string, boolean>>({
+  unused: true,
+  used: false,
+})
+
+const typeFilters = ref<Record<number, boolean>>(
+  componentTypes.value.reduce(
     (acc, type) => {
       acc[type.id] = true
       return acc
     },
-    {} as { [key: number]: boolean }
-  ),
-})
+    {} as Record<number, boolean>
+  )
+)
 
 const filteredComponents = computed(() => {
   return components.filter((component) => {
-    const isUsed = filters.showUsed && component.computerId !== null
-    const isUnused = filters.showUnused && component.computerId === null
-    const isTypeSelected = filters.types[component.type.id]
+    const isUsed = usageFilters.value.used && component.computerId !== null
+    const isUnused = usageFilters.value.unused && component.computerId === null
+    const isTypeSelected = typeFilters.value[component.type.id]
     return (isUsed || isUnused) && isTypeSelected
   })
 })
 </script>
 <template>
   <div>
-    <!-- Dropdown pour les filtres -->
     <div class="relative">
       <h4 class="text-xl underline">Filters</h4>
       <div class="flex gap-2">
-        <!-- Usage Dropdown -->
-        <div id="usage-selector" class="relative" style="width: fit-content">
-          <button
-            @click="toggleDropdown('usage')"
-            class="px-4 py-2 bg-indigo-600 text-white rounded hover:bg-blue-700 transition text-center inline-flex items-center"
-            type="button"
-          >
-            Usage
-            <svg
-              class="w-4 h-4 ml-2"
-              aria-hidden="true"
-              fill="none"
-              stroke="currentColor"
-              viewBox="0 0 24 24"
-              xmlns="http://www.w3.org/2000/svg"
-            >
-              <path
-                stroke-linecap="round"
-                stroke-linejoin="round"
-                stroke-width="2"
-                d="M19 9l-7 7-7-7"
-              ></path>
-            </svg>
-          </button>
-
-          <!-- Dropdown menu -->
-          <div
-            v-show="usageDropdownOpen"
-            class="absolute right-0 z-20 py-2 mt-2 bg-white rounded-md shadow-xl"
-          >
-            <ul class="space-y-2 text-sm px-4 py-2">
-              <li class="flex items-center">
-                <input
-                  id="unused"
-                  type="checkbox"
-                  v-model="filters.showUnused"
-                  class="w-4 h-4 bg-gray-100 border-gray-300 rounded text-primary-600 focus:ring-primary-500 dark:focus:ring-primary-600 dark:ring-offset-gray-700 focus:ring-2 dark:bg-gray-600 dark:border-gray-500"
-                />
-                <label
-                  for="unused"
-                  class="ml-2 text-sm font-medium text-gray-900 dark:text-gray-100"
-                >
-                  Unused
-                </label>
-              </li>
-              <li class="flex items-center">
-                <input
-                  id="used"
-                  type="checkbox"
-                  v-model="filters.showUsed"
-                  class="w-4 h-4 bg-gray-100 border-gray-300 rounded text-primary-600 focus:ring-primary-500 dark:focus:ring-primary-600 dark:ring-offset-gray-700 focus:ring-2 dark:bg-gray-600 dark:border-gray-500"
-                />
-                <label for="used" class="ml-2 text-sm font-medium text-gray-900 dark:text-gray-100">
-                  Used
-                </label>
-              </li>
-            </ul>
-          </div>
-        </div>
-
-        <!-- Type Dropdown -->
-        <div id="type-selector" class="relative" style="width: fit-content">
-          <button
-            @click="toggleDropdown('type')"
-            class="px-4 py-2 bg-indigo-600 text-white rounded hover:bg-blue-700 transition text-center inline-flex items-center"
-            type="button"
-          >
-            Types
-            <svg
-              class="w-4 h-4 ml-2"
-              aria-hidden="true"
-              fill="none"
-              stroke="currentColor"
-              viewBox="0 0 24 24"
-              xmlns="http://www.w3.org/2000/svg"
-            >
-              <path
-                stroke-linecap="round"
-                stroke-linejoin="round"
-                stroke-width="2"
-                d="M19 9l-7 7-7-7"
-              ></path>
-            </svg>
-          </button>
-
-          <!-- Dropdown menu -->
-          <div
-            v-show="typeDropdownOpen"
-            class="absolute right-0 z-20 py-2 mt-2 bg-white rounded-md shadow-xl"
-          >
-            <ul class="space-y-2 text-sm px-4 py-2">
-              <li class="flex items-center" v-for="type in componentTypes" :key="type.id">
-                <input
-                  :id="`type-${type.id}`"
-                  type="checkbox"
-                  v-model="filters.types[type.id]"
-                  class="w-4 h-4 bg-gray-100 border-gray-300 rounded text-primary-600 focus:ring-primary-500 dark:focus:ring-primary-600 dark:ring-offset-gray-700 focus:ring-2 dark:bg-gray-600 dark:border-gray-500"
-                />
-                <label
-                  :for="`type-${type.id}`"
-                  class="ml-2 text-sm font-medium text-gray-900 dark:text-gray-100"
-                >
-                  {{ type.name }}
-                </label>
-              </li>
-            </ul>
-          </div>
-        </div>
+        <FilterDropdown
+          v-model="usageFilters"
+          label="Usage"
+          :options="[
+            { id: 'unused', label: 'Unused' },
+            { id: 'used', label: 'Used' },
+          ]"
+        />
+        <FilterDropdown v-model="typeFilters" label="Types" :options="typeOptions" />
       </div>
     </div>
 
-    <!-- Tableau des composants filtr├®s -->
     <TableComponent :components="filteredComponents" />
   </div>
 </template>
diff --git a/inertia/pages/widgets/ComputersViewer.vue b/inertia/pages/widgets/ComputersViewer.vue
index f955fb4..68a7820 100644
--- a/inertia/pages/widgets/ComputersViewer.vue
+++ b/inertia/pages/widgets/ComputersViewer.vue
@@ -3,106 +3,45 @@ import { noImagePlaceholder } from '~/assets/images'
 import { usePage } from '@inertiajs/vue3'
 import Computer from '#models/computer'
 import ComputerCard from '~/pages/widgets/ComputerCard.vue'
-import { computed, reactive, ref } from 'vue'
+import FilterDropdown from '~/pages/widgets/FilterDropdown.vue'
+import { computed, ref } from 'vue'
 
 const { computers } = usePage<{ computers: Computer[] }>().props
-const stateDropdownOpen = ref(false)
 
-function toggleDropdown() {
-  stateDropdownOpen.value = !stateDropdownOpen.value
-}
-
-const filters = reactive({
+const filters = ref<Record<string, boolean>>({
   onGoing: true,
   finished: true,
   sold: false,
 })
+
+const stateToFilterKey: Record<string, string> = {
+  ON_GOING: 'onGoing',
+  FINISHED: 'finished',
+  SOLD: 'sold',
+}
+
 const filteredComputers = computed(() => {
   return computers.filter((computer) => {
-    const isOnGoing = filters.onGoing && computer.state.name == 'ON_GOING'
-    const isFinished = filters.finished && computer.state.name == 'FINISHED'
-    const isSold = filters.sold && computer.state.name == 'SOLD'
-    return isOnGoing || isFinished || isSold
+    const key = stateToFilterKey[computer.state.name]
+    return key ? filters.value[key] : false
   })
 })
 </script>
 
 <template>
   <div>
-    <!-- Dropdown pour les filtres -->
     <div class="relative">
       <h4 class="text-xl underline">Filters</h4>
       <div class="flex gap-2">
-        <!-- Usage Dropdown -->
-        <div id="usage-selector" class="relative" style="width: fit-content">
-          <button
-            @click="toggleDropdown()"
-            class="px-4 py-2 bg-indigo-600 text-white rounded hover:bg-blue-700 transition text-center inline-flex items-center"
-            type="button"
-          >
-            Usage
-            <svg
-              class="w-4 h-4 ml-2"
-              aria-hidden="true"
-              fill="none"
-              stroke="currentColor"
-              viewBox="0 0 24 24"
-              xmlns="http://www.w3.org/2000/svg"
-            >
-              <path
-                stroke-linecap="round"
-                stroke-linejoin="round"
-                stroke-width="2"
-                d="M19 9l-7 7-7-7"
-              ></path>
-            </svg>
-          </button>
-
-          <!-- Dropdown menu -->
-          <div
-            v-show="stateDropdownOpen"
-            class="absolute right-0 z-20 py-2 mt-2 bg-white rounded-md shadow-xl"
-          >
-            <ul class="space-y-2 text-sm px-4 py-2">
-              <li class="flex items-center">
-                <input
-                  id="unused"
-                  type="checkbox"
-                  v-model="filters.onGoing"
-                  class="w-4 h-4 bg-gray-100 border-gray-300 rounded text-primary-600 focus:ring-primary-500 dark:focus:ring-primary-600 dark:ring-offset-gray-700 focus:ring-2 dark:bg-gray-600 dark:border-gray-500"
-                />
-                <label
-                  for="unused"
-                  class="ml-2 text-sm font-medium text-gray-900 dark:text-gray-100"
-                >
-                  On Going
-                </label>
-              </li>
-              <li class="flex items-center">
-                <input
-                  id="used"
-                  type="checkbox"
-                  v-model="filters.finished"
-                  class="w-4 h-4 bg-gray-100 border-gray-300 rounded text-primary-600 focus:ring-primary-500 dark:focus:ring-primary-600 dark:ring-offset-gray-700 focus:ring-2 dark:bg-gray-600 dark:border-gray-500"
-                />
-                <label for="used" class="ml-2 text-sm font-medium text-gray-900 dark:text-gray-100">
-                  Finished
-                </label>
-              </li>
-              <li class="flex items-center">
-                <input
-                  id="used"
-                  type="checkbox"
-                  v-model="filters.sold"
-                  class="w-4 h-4 bg-gray-100 border-gray-300 rounded text-primary-600 focus:ring-primary-500 dark:focus:ring-primary-600 dark:ring-offset-gray-700 focus:ring-2 dark:bg-gray-600 dark:border-gray-500"
-                />
-                <label for="used" class="ml-2 text-sm font-medium text-gray-900 dark:text-gray-100">
-                  Sold
-                </label>
-              </li>
-            </ul>
-          </div>
-        </div>
+        <FilterDropdown
+          v-model="filters"
+          label="Usage"
+          :options="[
+            { id: 'onGoing', label: 'On Going' },
+            { id: 'finished', label: 'Finished' },
+            { id: 'sold', label: 'Sold' },
+          ]"
+        />
       </div>
       <div class="mt-4 mb-3 grid grid-cols-1 sm:grid-cols-2 md:grid-cols-3 xl:grid-cols-4 gap-4">
         <ComputerCard
@@ -119,5 +58,3 @@ const filteredComputers = computed(() => {
     </div>
   </div>
 </template>
-
-<style scoped></style>
diff --git a/inertia/pages/widgets/FilterDropdown.vue b/inertia/pages/widgets/FilterDropdown.vue
new file mode 100644
index 0000000..c89970a
--- /dev/null
+++ b/inertia/pages/widgets/FilterDropdown.vue
@@ -0,0 +1,72 @@
+<script setup lang="ts">
+import { ref } from 'vue'
+
+interface FilterOption {
+  id: string | number
+  label: string
+}
+
+defineProps<{
+  label: string
+  options: FilterOption[]
+}>()
+
+const modelValue = defineModel<Record<string | number, boolean>>({ required: true })
+
+const isOpen = ref(false)
+
+function toggle() {
+  isOpen.value = !isOpen.value
+}
+</script>
+
+<template>
+  <div class="relative" style="width: fit-content">
+    <button
+      type="button"
+      class="px-4 py-2 bg-indigo-600 text-white rounded hover:bg-blue-700 transition text-center inline-flex items-center"
+      :aria-expanded="isOpen"
+      aria-haspopup="true"
+      @click="toggle"
+    >
+      {{ label }}
+      <svg
+        class="w-4 h-4 ml-2"
+        aria-hidden="true"
+        fill="none"
+        stroke="currentColor"
+        viewBox="0 0 24 24"
+        xmlns="http://www.w3.org/2000/svg"
+      >
+        <path
+          stroke-linecap="round"
+          stroke-linejoin="round"
+          stroke-width="2"
+          d="M19 9l-7 7-7-7"
+        ></path>
+      </svg>
+    </button>
+
+    <div
+      v-show="isOpen"
+      class="absolute right-0 z-20 py-2 mt-2 bg-white rounded-md shadow-xl"
+    >
+      <ul class="space-y-2 text-sm px-4 py-2">
+        <li v-for="option in options" :key="option.id" class="flex items-center">
+          <input
+            :id="`filter-${label}-${option.id}`"
+            v-model="modelValue[option.id]"
+            type="checkbox"
+            class="w-4 h-4 bg-gray-100 border-gray-300 rounded text-primary-600 focus:ring-primary-500 dark:focus:ring-primary-600 dark:ring-offset-gray-700 focus:ring-2 dark:bg-gray-600 dark:border-gray-500"
+          />
+          <label
+            :for="`filter-${label}-${option.id}`"
+            class="ml-2 text-sm font-medium text-gray-900 dark:text-gray-100"
+          >
+            {{ option.label }}
+          </label>
+        </li>
+      </ul>
+    </div>
+  </div>
+</template>