From ab45275a89055f1d45bc8cf522e8f999e7879558 Mon Sep 17 00:00:00 2001
From: Kevin L'Hereec <kevin.lhereec@orange.com>
Date: Mon, 20 Jul 2026 16:39:53 +0200
Subject: [PATCH] fix: SetParameterAttributes XML emits 0/1 for boolean fields
 and drops xsi:type on Notification
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

NotificationChange and AccessListChange were emitting 'true'/'false' (JS booleans)
instead of '1'/'0' as required by TR-069 spec.
Notification xsi:type='xsd:int' attribute removed — consistent with old builder output.
---
 app/protocol/cwmp-1-0.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/protocol/cwmp-1-0.ts b/app/protocol/cwmp-1-0.ts
index 5e10b0e..622d79c 100644
--- a/app/protocol/cwmp-1-0.ts
+++ b/app/protocol/cwmp-1-0.ts
@@ -369,9 +369,9 @@ export class SetParameterAttributes {
       this.ParameterList?.SetParameterAttributesStruct?.map((attr) => {
         return `<SetParameterAttributesStruct>
                     <Name xsi:type="xsd:string">${attr.Name}</Name>
-                    <NotificationChange>${attr.NotificationChange}</NotificationChange>
-                    <Notification xsi:type="xsd:int">${attr.Notification}</Notification>
-                    <AccessListChange>${attr.AccessListChange}</AccessListChange>
+                    <NotificationChange>${attr.NotificationChange ? 1 : 0}</NotificationChange>
+                    <Notification>${attr.Notification}</Notification>
+                    <AccessListChange>${attr.AccessListChange ? 1 : 0}</AccessListChange>
                     <AccessList soap-enc:arrayType="xsd:string[${attr.AccessList?.string?.length ?? 0}]">${attr.AccessList ? attr.AccessList.string!.join(', ') : ''}</AccessList>
                 </SetParameterAttributesStruct>`
       }).join('') || ''